Skip to content

Conversation

@kemingy
Copy link
Contributor

@kemingy kemingy commented Aug 1, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

The SIGSEGV is from the s.into(), which convert the Statement:

  • from sqlparser-rs-6d6510b5e3af714f
  • to sqlparser-0.54.0

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@kemingy kemingy requested a review from a team as a code owner August 1, 2025 16:22
@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Aug 1, 2025
@kemingy kemingy requested review from evenyag and v0y4g3r as code owners August 3, 2025 15:53
@github-actions github-actions bot added size/M and removed size/XS labels Aug 3, 2025
@kemingy kemingy marked this pull request as draft August 3, 2025 15:54
@kemingy kemingy changed the title fix: reinterpret Statement between different sqlparser version fix: bump greptime-sqlparser to avoid convert statement overflow Aug 3, 2025
Signed-off-by: Keming <[email protected]>

Co-authored-by: Keming <[email protected]>
Co-authored-by: Yihong <[email protected]>
@kemingy kemingy force-pushed the transmute_statement branch from 897124c to 067b51e Compare August 3, 2025 16:01
@github-actions github-actions bot added size/XS and removed size/M labels Aug 3, 2025
@kemingy kemingy marked this pull request as ready for review August 3, 2025 16:01
@kemingy
Copy link
Contributor Author

kemingy commented Aug 3, 2025

cc @sunng87

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for taking this

@waynexia waynexia enabled auto-merge August 3, 2025 19:07
@waynexia waynexia added this pull request to the merge queue Aug 4, 2025
Merged via the queue into GreptimeTeam:main with commit bed0c1e Aug 4, 2025
51 of 57 checks passed
@kemingy kemingy deleted the transmute_statement branch August 4, 2025 02:45
zhongzc pushed a commit that referenced this pull request Aug 6, 2025
sunheyi6 pushed a commit to sunheyi6/greptimedb that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when there are too many WHERE conditions in the SQL query

3 participants